Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement map_pcs_to_sierra_statement_ids function #5

Merged
merged 6 commits into from
Oct 1, 2024
Merged

Implement map_pcs_to_sierra_statement_ids function #5

merged 6 commits into from
Oct 1, 2024

Conversation

ksew1
Copy link
Member

@ksew1 ksew1 commented Sep 27, 2024

Closes #4

@ksew1 ksew1 linked an issue Sep 27, 2024 that may be closed by this pull request
Implement map_pcs_to_sierra_statement_ids function #4
Closed
THenry14
THenry14 approved these changes Oct 1, 2024
View reviewed changes
Copy link
Member

@THenry14 THenry14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, comments I left are rather nitpick-y.
great job 💪

Cargo.toml Outdated Show resolved Hide resolved
crates/cairo-annotations/Cargo.toml Outdated Show resolved Hide resolved
crates/cairo-annotations/tests/data/scarb_template/Scarb.toml Outdated Show resolved Hide resolved
Base automatically changed from github-folder to main October 1, 2024 13:20
@ksew1 ksew1 merged commit 2de4ca2 into main Oct 1, 2024
4 checks passed
@ksew1 ksew1 deleted the map-pcs-to-sierra-statement-ids branch October 1, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@THenry14 THenry14 THenry14 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement map_pcs_to_sierra_statement_ids function
2 participants
@ksew1 @THenry14