code review changes

software-mansion · Feb 19, 2025 · 8591ff1 · 8591ff1
1 parent 56fbd7e
commit 8591ff1
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 9 deletions.
diff --git a/packages/vscode-extension/lib/instrumentation.js b/packages/vscode-extension/lib/instrumentation.js
@@ -186,15 +186,15 @@ function onCommitFiberRoot(_rendererID, root) {
   onRender(renderedFibers);
 }
 
-export const setInstrumentationOptions = (partialOptions) => {
+export const updateInstrumentationOptions = (partialOptions) => {
   const componentBlocklist = partialOptions.componentBlocklist
     ? new Set(partialOptions.componentBlocklist)
     : options.componentBlocklist;
   options = { ...options, componentBlocklist, ...partialOptions };
   if (!inited) {
     inited = true;
     instrument({
-      onCommitFiberRoot: (rendererID, root) => onCommitFiberRoot(rendererID, root),
+      onCommitFiberRoot,
     });
   }
 };
diff --git a/packages/vscode-extension/lib/wrapper.js b/packages/vscode-extension/lib/wrapper.js
@@ -39,8 +39,8 @@ const InternalImports = {
   get reduxDevtoolsExtensionCompose() {
     return require("./plugins/redux-devtools").compose;
   },
-  get setInstrumentationOptions() {
-    return require("./instrumentation").setInstrumentationOptions;
+  get updateInstrumentationOptions() {
+    return require("./instrumentation").updateInstrumentationOptions;
   },
 };
 
@@ -416,7 +416,7 @@ export function AppWrapper({ children, initialProps, fabric }) {
     if (!devtoolsAgent) {
       return;
     }
-    InternalImports.setInstrumentationOptions({
+    InternalImports.updateInstrumentationOptions({
       reportRenders: (blueprintOutlines) => {
         devtoolsAgent._bridge.send("RNIDE_rendersReported", { blueprintOutlines });
       },
@@ -427,9 +427,9 @@ export function AppWrapper({ children, initialProps, fabric }) {
   // TODO: get initial options when the app starts
   useAgentListener(
     devtoolsAgent,
-    "RNIDE_setInstrumentationOptions",
+    "RNIDE_updateInstrumentationOptions",
     (payload) => {
-      InternalImports.setInstrumentationOptions(payload);
+      InternalImports.updateInstrumentationOptions(payload);
     },
     []
   );

diff --git a/packages/vscode-extension/src/plugins/render-outlines/render-outlines-plugin.ts b/packages/vscode-extension/src/plugins/render-outlines/render-outlines-plugin.ts
@@ -19,7 +19,7 @@ export class RenderOutlinesPlugin implements ToolPlugin, RenderOutlinesInterface
       this.eventEmitter.emit("rendersReported", payload);
     }
     if (event === "RNIDE_queryInstrumentationOptions") {
-      this.devtools.send("RNIDE_setInstrumentationOptions", { isEnabled: this.isEnabled });
+      this.devtools.send("RNIDE_updateInstrumentationOptions", { isEnabled: this.isEnabled });
     }
   };
 
@@ -45,7 +45,7 @@ export class RenderOutlinesPlugin implements ToolPlugin, RenderOutlinesInterface
 
   setEnabled(isEnabled: boolean) {
     this.isEnabled = isEnabled;
-    this.devtools.send("RNIDE_setInstrumentationOptions", { isEnabled });
+    this.devtools.send("RNIDE_updateInstrumentationOptions", { isEnabled });
   }
 
   addEventListener<K extends keyof RenderOutlinesEventMap>(