Start separate debug adapters for Metro and JS debugging #1008
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
| this.connectJSDebugger(configuration as unknown as CDPConfiguration); | ||
| } | ||
|
|
||
| private connectJSDebugger(cdpConfiguration: CDPConfiguration) { |
There was a problem hiding this comment.
I am getting confused by the nameing convention here, is JS debugger the parrent debugger or the debugger for applications, I think it would be good to introduce consistant naming convention for example: JSDebuger or parentDebugger for the top one and cdpDebugger, applicationDebugger or ReactNtiveDebugger for the bottom one.
Note: I know it might be me mistake in #964 originally sorry about that
There was a problem hiding this comment.
"JS Debugger" is the child of the "React Native Debugger" (which just forwards the metro logs at this point), not the other way around.
This method should probably be just called startCDPSession or connectToApplication, since we're already in the "debugger" (or rather "debugger adapter") implementation here.
jwajgelt
force-pushed
the
@jwajgelt/refactor_debug_adapter
branch
from
1f33ec7 to
ec228d3
Compare
Refactors the changes introduced in #964 to separate logging metro messages and JS debugging into separate DAP Sessions. This will also make integrating #1001 easier with other changes made to
DebugAdapter.How Has This Been Tested:
Open an app and check the debugger still works correctly: