MultiRoot Workspace support #663

filip131311 · 2024-10-25T20:34:56Z

This PR refactors how we handle the appRoot to allow for changing it in runtime. To make sure that the app root is unified across all the components we now store it in project.ts and move all objects dependent on appRoot to project as well. We listen for launchConfiguration changes and restart everything dependent on appRoot after it changes.
We refactor how appRoot is detected:
after analyzing the old approach that was using workspace.findFiles we realized that on more elaborate setups it took almost 2 seconds to traverse all of the workspace directories. To combat that we introduce a new findAppRootCandidates implementation that takes only a couple of ms in most setups.
note: the new function is not perfectly equivalent to the old one as it removes a check if node_modules contains react-native it is done on purpose as it has a following drawbacks:

generetes false positives as some not applications directories (e.g. libries) might contain react-native in its node modules,
mono repositories might generate false positives at top level depending on the implementation
it requires searching through node_modules which are usually quite large
it is not even that useful, because it requires node_modules to be installed and first time users could encounter problems if we relied on this check.

Additionally we enhance the Lunch Configuration View to allow the user for selecting the appRoot from the list.

How has dis been tested?

Run the mono repo with 2 application and switch between them.
Run react-native-svg repo and select test apps in it
Run react-native-reanimated repo and select test apps in it, additionally check if cashes are stored properly after switching between applications.
To benchmark the findAppRootCandidates I added the following code to at the end of the activate function in the extension:

const start = performance.now();

  await findAppRootFolder() 

  const end = performance.now()

  Logger.debug("My benchmark result:", end-start);

note: that the benchmark make sens only if you don't have appRoot set in launchConfiguration.

Results for react-native-reanimated repository:

old	new
1479.05 ms	1.27 ms

vercel · 2024-10-25T20:35:00Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
radon-ide	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Feb 28, 2025 0:42am

This PR add a possibility to reboot the reboot device, metro and devtools processes without triggering clean build. It was previously only possible by closing and reopening the IDE panel itself. This also will provide necessary functionality for #663 ### How Has This Been Tested: - run an application and pick "Reboot IDE" option from reload dropdown menu

This PR changes a way we manage build caches. Previous approach was dependent on current vscode workspace, which led to build caches not being accessible when switching from working in the root of the workspace to the root of the application (or doing the same in reverse). The new approach saves this data in global storage, and adds a appRoot identifier to the cache key. This PR is a dependency for #663 ### How Has This Been Tested: - Open a project in the root of the workspace and run some application that is part of it in the IDE. - Open IDE in the root of that application and see if the build cache is loaded. - repeat the proces in reverse - open an application that had a build made before this change and check if migration process works as expected Verify that the build cache migration work: - Build project without these changes - Open the same project with no changes but with the new version of extension – expect the cache hit for native build --------- Co-authored-by: Krzysztof Magiera <[email protected]>

packages/vscode-extension/src/builders/customBuild.ts

packages/vscode-extension/src/utilities/extensionContext.ts

jwajgelt · 2025-02-27T13:45:46Z

packages/vscode-extension/src/utilities/packageManager.ts

+export async function isNodeModulesInstalled(
+  manager: PackageManagerInfo,
+  appRoot: string


Maybe PackageManagerInfo should hold the appRoot instead? Isn't the "Package Manager Info" only relevant in the context of a specific "app root"?

I'm not sure if it ever gonna be useful in the future, but it is not. You theoretically can call nmp install in any workspace directory and with the correct setiting all of the will be installed

Yes, but PackageManagerInfo contains the information on which package manager should be used which, if I understand correctly, depends on the contents of appRoot, no? Can't changing the app root could cause the selected package manager to change?

It sometimes could, but it is unlikely, but at the end of the day the important question is not if those values are sometimes related but if there might be the situation ever of changing only one of them and as I have written above there might be

But this is exactly what I mean -- if you change the appRoot you probably want to recreate the PackageManagerInfo, right?
The way it's written right now, you supply them separately, so you may provide the "wrong" PackageManagerInfo, i.e. one unrelated to the passed appRoot.

packages/vscode-extension/src/webview/providers/LaunchConfigProvider.tsx

packages/vscode-extension/src/project/project.ts

packages/vscode-extension/src/utilities/extensionContext.ts

jwajgelt · 2025-02-28T08:16:00Z

packages/vscode-extension/src/utilities/extensionContext.ts

+      )
+      .then((item) => {
+        if (item === openLaunchConfigButton) {
+          commands.executeCommand("workbench.action.debug.configure");


Is this the correct action for this? For me it opens the command palette, while I'd expect it to open our launch configuration menu (where I can actually select the app root).

I don't know why it opens a command palet for you, It works for me and opens a correct configuration file, In the future i would love to migrete to opening our configuration panel but i feel like it is not stable enough yet.

could you run this comand from command palet and see what happens? do you use cursor or vs code?

VSCode.
It's probably because I don't have the file in that project.

packages/vscode-extension/src/project/applicationContext.ts

packages/vscode-extension/src/utilities/extensionContext.ts

packages/vscode-extension/src/project/applicationContext.ts

vercel bot deployed to Preview October 25, 2024 20:39 View deployment

kmagiera marked this pull request as draft October 29, 2024 08:28

This was referenced Oct 29, 2024

Fix build cache management in workspaces #675

Merged

Implement reboot functionality #680

Merged

vercel bot deployed to Preview December 19, 2024 14:49 View deployment

vercel bot deployed to Preview December 19, 2024 14:54 View deployment

vercel bot deployed to Preview December 19, 2024 15:40 View deployment

filip131311 marked this pull request as ready for review December 19, 2024 15:41

filip131311 requested a review from kmagiera December 20, 2024 09:40

filip131311 changed the title ~~Draft of MultiRoot Workspace support~~ MultiRoot Workspace support Dec 20, 2024

filip131311 force-pushed the @Filip131311/FixMultiRootWorkspaces branch from 0f8aa95 to 76da6d1 Compare January 17, 2025 14:45

vercel bot deployed to Preview January 17, 2025 14:46 View deployment

filip131311 force-pushed the @Filip131311/FixMultiRootWorkspaces branch from 76da6d1 to 9317a59 Compare January 17, 2025 14:57

vercel bot deployed to Preview January 17, 2025 14:57 View deployment

vercel bot deployed to Preview January 17, 2025 15:17 View deployment

vercel bot deployed to Preview February 13, 2025 11:07 View deployment

vercel bot deployed to Preview February 13, 2025 11:14 View deployment

vercel bot deployed to Preview February 19, 2025 14:18 View deployment

init - everything expect device session and build cache

3dc45d4

filip131311 force-pushed the @Filip131311/FixMultiRootWorkspaces branch from df78b95 to 3dc45d4 Compare February 26, 2025 22:05

vercel bot deployed to Preview February 26, 2025 22:05 View deployment

build cache

1a902be

vercel bot deployed to Preview February 26, 2025 22:39 View deployment

device session

292b250

vercel bot deployed to Preview February 26, 2025 22:52 View deployment

filip131311 added 2 commits February 27, 2025 10:50

Merge branch 'main' into @Filip131311/FixMultiRootWorkspaces

7c4bbd2

exclude pattern instead of exact string matching

accf953

jwajgelt requested changes Feb 27, 2025

View reviewed changes

code review

229d1b4

vercel bot deployed to Preview February 27, 2025 18:59 View deployment

format

e0261fc

vercel bot deployed to Preview February 27, 2025 19:11 View deployment

filip131311 requested review from kmagiera and jwajgelt February 27, 2025 19:36

jwajgelt requested changes Feb 28, 2025

View reviewed changes

jwajgelt reviewed Feb 28, 2025

View reviewed changes

CR

ba7f330

vercel bot deployed to Preview February 28, 2025 09:48 View deployment

CR

d701999

vercel bot deployed to Preview February 28, 2025 09:53 View deployment

CR

5dcd216

vercel bot deployed to Preview February 28, 2025 10:01 View deployment

lint

b23987b

vercel bot deployed to Preview February 28, 2025 10:02 View deployment

marge main

8e18b0a

vercel bot deployed to Preview February 28, 2025 10:06 View deployment

CR

d97f8ce

vercel bot deployed to Preview February 28, 2025 10:38 View deployment

jwajgelt requested changes Feb 28, 2025

View reviewed changes

CR

aae573a

vercel bot deployed to Preview February 28, 2025 11:42 View deployment

jwajgelt approved these changes Feb 28, 2025

View reviewed changes

filip131311 added 2 commits February 28, 2025 13:41

some commit

76eb229

some commit

a6ee667

vercel bot deployed to Preview February 28, 2025 12:42 View deployment

filip131311 merged commit 9b4ab57 into main Feb 28, 2025
4 checks passed

filip131311 deleted the @Filip131311/FixMultiRootWorkspaces branch February 28, 2025 12:44

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

MultiRoot Workspace support #663

MultiRoot Workspace support #663

filip131311 commented Oct 25, 2024 •

edited

Loading

vercel bot commented Oct 25, 2024 •

edited

Loading

jwajgelt Feb 27, 2025

filip131311 Feb 27, 2025

jwajgelt Feb 28, 2025

filip131311 Feb 28, 2025

jwajgelt Feb 28, 2025 •

edited

Loading

jwajgelt Feb 28, 2025

filip131311 Feb 28, 2025

filip131311 Feb 28, 2025

jwajgelt Feb 28, 2025

MultiRoot Workspace support #663

MultiRoot Workspace support #663

Conversation

filip131311 commented Oct 25, 2024 • edited Loading

How has dis been tested?

vercel bot commented Oct 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

jwajgelt Feb 28, 2025 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

filip131311 commented Oct 25, 2024 •

edited

Loading

vercel bot commented Oct 25, 2024 •

edited

Loading

jwajgelt Feb 28, 2025 •

edited

Loading