Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a fallback path to the end of the path variable #995

Merged
merged 1 commit into from
Feb 28, 2025

Conversation

filip131311
Copy link
Collaborator

This PR fixes the issue introduced by #975, that was causing for the path variable to be incomplete.
The problem could be surfaced when trying to use sim-server fingerprint functionality as it relies on the PATH variable.

The solution is to in addition to the new path finding method, append the old path at the end of the new one to fill in any missing paths.

How Has This Been Tested:

  • Run react-native-78 test app
  • add license

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 11:19am

Copy link
Member

@kacperkapusciak kacperkapusciak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change fixes an issue I had with license activation on main with error message Error: Empty result machine ID

Before

unnamed (3)

After

Screenshot 2025-02-28 at 12 34 44

So I'm happy with this change

@filip131311 filip131311 merged commit 12ed4f2 into main Feb 28, 2025
4 checks passed
@filip131311 filip131311 deleted the @Filip131311/FixPathEnvVariable3 branch February 28, 2025 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants