Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pass a concrete port number to Metro #998

Merged
merged 1 commit into from
Mar 3, 2025
Merged

Conversation

jwajgelt
Copy link
Contributor

Passes a concrete port number (picked by getting an ephemeral port briefly assigned by the OS and then releasing it) to Metro instead of "0", which causes issues with Metro's internal implementation.

How Has This Been Tested:

Open the various test apps in the test-apps repo and verify the packager connects.

Copy link

vercel bot commented Feb 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
radon-ide ✅ Ready (Inspect) Visit Preview 💬 Add feedback Feb 28, 2025 3:06pm

Copy link
Member

@kmagiera kmagiera left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@jwajgelt jwajgelt merged commit e339c0d into main Mar 3, 2025
4 checks passed
@jwajgelt jwajgelt deleted the @jwajgelt/pass_port_to_metro branch March 3, 2025 06:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants