refactor(Android): cleanup sheet behavior configuration #2420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alduzy
reviewed
Oct 21, 2024
Comment on lines
+18
to
+19
| firstHeight: Int? = null, | ||
| secondHeight: Int? = null |
There was a problem hiding this comment.
Wouldn't it be better to stick with the original "peekHeight" and "maxHeight"?
Same applies to useSingleDetent and useThreeDetents.
There was a problem hiding this comment.
My intention was to abstract the BottomSheetBehavior properties away as much as possible, because peekHeight is not the "first detent heightandmaxHeightis notsecondHeight` in general. They serve these functions only when other properties are set appropriately.
I've yet failed to abstract it away from useThreeDetents, because situation is a little bit more complicated there & requires another refactor, which will come in the future.
alduzy
approved these changes
Oct 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I plant to extract most of the form sheet API related code out of
ScreenStackFragment,so that it is not polluted that much and more readable. Having experienced the #2045, where
big changes were rolled out at once, now I want to do it in couple of separate PRs.
This one simplifies sheet behaviour configuration logic in ScreenStackFragment by implementing
series of helper extension functions on BottomSheetBehavior.
Test code and steps to reproduce
Test1649
Checklist