Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Initial implementation of RegistrySource #790

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Initial implementation of RegistrySource #790

merged 1 commit into from
Oct 25, 2023

Conversation

mkaput
Copy link
Member

@mkaput mkaput commented Oct 11, 2023 •
edited
Loading

This implementation focuses solely on local registries, and it has almost no security.

Stack:

⚠️ Part of a stack created by spr. Do not merge manually using the UI - doing so may have unexpected results.

This was referenced Oct 11, 2023
Merged
Merged
Merged
@mkaput mkaput changed the base branch from spr/main/2f86491f to main October 11, 2023 14:51
@mkaput mkaput changed the base branch from main to spr/main/63588ff9 October 11, 2023 14:52
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from f89d721 to a528b57 Compare October 11, 2023 14:52
@mkaput mkaput marked this pull request as draft October 11, 2023 14:52
github-merge-queue bot pushed a commit that referenced this pull request Oct 11, 2023
@mkaput
Add tracing instrumentation to package ops (#789)
7475530 
**Stack**:
- #790
- #783
- #767
- #789 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput changed the base branch from spr/main/63588ff9 to main October 12, 2023 15:15
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from a528b57 to 3306963 Compare October 12, 2023 15:15
This was referenced Oct 12, 2023
Merged
Merged
Closed
@mkaput mkaput changed the base branch from main to spr/main/d57e36fd October 12, 2023 15:15
@mkaput mkaput marked this pull request as ready for review October 12, 2023 15:16
@mkaput mkaput requested review from maciektr and szymmis October 12, 2023 15:16
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from 3306963 to 4275e61 Compare October 12, 2023 15:19
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2023
@mkaput
Implement base data models for registry index (#767)
658fb89 
**Stack**:
- #794
- #793
- #790
- #792
- #783
- #767 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
@mkaput mkaput force-pushed the spr/main/d57e36fd branch from 90fcd2f to 5acc502 Compare October 16, 2023 08:56
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from 4275e61 to e7ff6a5 Compare October 16, 2023 08:56
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2023
@mkaput
Implement Checksum and Digest mechanisms (#783)
e5b673a 
**Stack**:
- #793
- #790
- #792
- #783 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
szymmis
szymmis approved these changes Oct 16, 2023
View reviewed changes
scarb/src/core/registry/client/local.rs Outdated Show resolved Hide resolved
mkaput added a commit that referenced this pull request Oct 16, 2023
@mkaput
Add basic tests for local registry
0bb2309 
These tests depend on both #790 and #793, hence they come in separate PR.

commit-id:f99f264b
@mkaput mkaput mentioned this pull request Oct 16, 2023
Merged
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from e7ff6a5 to 34a8beb Compare October 16, 2023 11:38
@mkaput mkaput force-pushed the spr/main/d57e36fd branch from 5acc502 to 6777b6c Compare October 16, 2023 11:38
github-merge-queue bot pushed a commit that referenced this pull request Oct 16, 2023
@mkaput
Fix ops::package leaving old path in created FileLockGuard (#792)
f803c6c 
**Stack**:
- #798
- #793
- #790
- #792 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Base automatically changed from spr/main/d57e36fd to main October 16, 2023 12:04
mkaput added a commit that referenced this pull request Oct 16, 2023
@mkaput
Add basic tests for local registry
68be284 
These tests depend on both #790 and #793, hence they come in separate PR.

commit-id:f99f264b
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from 34a8beb to e2c031d Compare October 16, 2023 14:16
This was referenced Oct 16, 2023
Merged
Merged
Merged
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch 2 times, most recently from b53610b to 780d9a5 Compare October 19, 2023 07:34
This was referenced Oct 19, 2023
Merged
Merged
Merged
Merged
Merged
@mkaput mkaput requested review from maciektr and szymmis October 23, 2023 17:49
@mkaput
Initial implementation of RegistrySource
b81231d 
This implementation focuses solely on local registries, and it has almost no security.

commit-id:7c1e1d67
This was referenced Oct 23, 2023
Merged
Merged
@mkaput mkaput force-pushed the spr/main/7c1e1d67 branch from 780d9a5 to b81231d Compare October 23, 2023 17:59
@mkaput mkaput added this pull request to the merge queue Oct 25, 2023
Merged via the queue into main with commit b78262e Oct 25, 2023
@mkaput mkaput deleted the spr/main/7c1e1d67 branch October 25, 2023 11:54
github-merge-queue bot pushed a commit that referenced this pull request Oct 27, 2023
@mkaput
Add basic tests for local registry (#798)
0b65002 
These tests depend on both #790 and #793, hence they come in separate
PR.

---

**Stack**:
- #819
- #818
- #809
- #808
- #807
- #806
- #805
- #803
- #802
- #799
- #798 ⬅


⚠️ *Part of a stack created by [spr](https://github.com/ejoffe/spr). Do
not merge manually using the UI - doing so may have unexpected results.*
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szymmis szymmis szymmis approved these changes

@maciektr maciektr maciektr approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mkaput @maciektr @szymmis