Remove accounts #165
Merged
Remove accounts #165
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jennifercheukyin
approved these changes
Dec 5, 2021
|
Looks awesome! Thanks for doing this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related to #6.
This PR aims to allow users to remove accounts they may not want to see.
access_tokenwhen user opts to remove this accountFor simplicity, removing an account means removing the
access_tokenassociated with it. The reason for doing so is that if users want to remove individual cards/banks associated with each account, then they would not be able to re-add them. In addition, once they remove an account, they will never be able to add it again if we do not completely remove theaccess_token(since we prevent duplicates now).