-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[scala3] Add test for serializable generated type-class #499
[scala3] Add test for serializable generated type-class #499
Conversation
d4fa285
to
53104d7
Compare
@RustedBones our projects use https://github.com/sbt/sbt-projectmatrix, in my experience this is the only sane way to maintain projects with both simple & complex cross-platform setups. I think adding the test in |
Ok, let's stick with |
53104d7
to
6d9d096
Compare
Any take on this one? |
It would be great if this PR can be reviewed / merged, since it's blocking scio migration towards Scala 3. |
@turb ah sorry, this somehow fell through the cracks. There's a conflict, otherwise it looks good. |
@turb would you be able to create an updated PR maybe? |
I suppose @RustedBones may prefer to do it himself since it's his PR, but if he's busy I will. |
6d9d096
to
2a6e7ab
Compare
2a6e7ab
to
89a23e2
Compare
Thanks all! :) |
Scala3 version of magnolia does not generate serializable typeclass when defined inside a non-serializable outer, unlike the scala 2 version. Tested in #498.
It looks like the
summonInline[Typeclass[p]]
lambda in theCallByNeed
takes a reference on the outer obejct.