Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug]: FRSM-13-2 does not detect files as expected #35

Closed
karacolada opened this issue Jun 3, 2024 · 0 comments · Fixed by #37
Closed

[Bug]: FRSM-13-2 does not detect files as expected #35

karacolada opened this issue Jun 3, 2024 · 0 comments · Fixed by #37
Assignees
@karacolada
Labels
bug Something isn't working

Comments

@karacolada
Copy link
Member

Description

FRSM-13-2 fails for https://github.com/bojanakoteska/SchrodingerAPI.

Expected Behavior

FRSM-13-2 should pass for https://github.com/bojanakoteska/SchrodingerAPI.

Actual Behavior

Does not detect requirements.txt or keywords in GitHub actions file.

Possible Fix

Adjust detection logic in FAIREvaluatorRequirements and patterns in data/software_file.json.

Steps to reproduce

https://github.com/bojanakoteska/SchrodingerAPI

Your Environment

  • python --version: 3.11.5
  • pip show fuji | grep "^Version\:": Version: 3.1.1
@karacolada karacolada added the bug Something isn't working label Jun 3, 2024
@karacolada karacolada self-assigned this Jun 3, 2024
This was referenced Jun 3, 2024
Closed
Merged
@karacolada karacolada linked a pull request Jun 3, 2024 that will close this issue
adjusted FRSM-13 detection logic #37
Merged
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@karacolada karacolada

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adjusted FRSM-13 detection logic softwaresaved/fuji
1 participant
@karacolada