Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

adjusted FRSM-13 detection logic #37

Merged

Conversation

karacolada
Copy link
Member

Description

Fixes bug #35 where FRSM-13-2 was not detecting files as expected.

Related issue: #35

Motivation and context

Fixes bug linked above.

How has this been tested?

Ran automated tests, and tested manually against https://github.com/bojanakoteska/SchrodingerAPI and https://github.com/softwaresaved/fuji.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

Checklist

  • I have read the contributor guide.
  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@karacolada karacolada linked an issue Jun 3, 2024 that may be closed by this pull request
@karacolada karacolada self-assigned this Jun 3, 2024
@karacolada karacolada changed the title adjusted detection logic adjusted FRSM-13 detection logic Jun 3, 2024
Copy link

github-actions bot commented Jun 3, 2024

📋 Code Coverage

Code Coverage

Package Line Rate Branch Rate Health
. 61% 35%
config 100% 100%
controllers 86% 56%
evaluators 48% 27%
harvester 58% 48%
helper 65% 55%
models 75% 85%
Summary 63% (7719 / 12179) 55% (3306 / 6028)

Copy link

github-actions bot commented Jun 3, 2024

📋 Pytest Results

19 tests  ±0   19 ✅ ±0   24s ⏱️ -11s
 1 suites ±0    0 💤 ±0 
 1 files   ±0    0 ❌ ±0 

Results for commit 2d21e18. ± Comparison against base commit 1778e73.

@karacolada karacolada merged commit 083deb1 into master Jun 3, 2024
4 checks passed
@karacolada karacolada mentioned this pull request Jun 3, 2024
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: FRSM-13-2 does not detect files as expected
1 participant