Fix: add missing stop function in the Simulation using pybind #246
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit fixes an error when using the dpsim python interface. The stop function was not declared in the pybind/main.cpp and then not exposed in python. Signed-off-by: Leonardo Carreras <[email protected]>
leonardocarreras
merged commit a8055d8
into
sogno-platform:hotfix-missing-simulation-stop
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit fixes an error when using the dpsim python interface (
dpsimpy).The stop function was not declared in the
pybind/main.cppand then not exposed in python. The result was that the program gets an exception and the last data is not written to the output.A line was added to expose the
stopfunction.