Adapt DPsim to deploy it in Mybinder #323
Draft
+140
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipeacosta
requested review from
m-mirz,
stv0g,
dinkelbachjan,
n-eiling,
gnakti and
leonardocarreras
as code owners
|
Wow, there are a lot of conflicts :( Do you think we can resolve them @pipeacosta? Or would it be better to start from scratch? |
Hi @stv0g. Do you mean the fact that the commit history is a bit messed? |
|
Yes, partially. This PR has 250 commits :o But also:
|
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: Steffen Vogel <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: pipeacosta <[email protected]>
Signed-off-by: Andres Acosta <[email protected]>
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Signed-off-by: Andres Acosta <[email protected]>
Hi @stv0g. Does it look better now? |
Signed-off-by: pipeacosta <[email protected]>
|
| libnl3-devel | ||
|
|
||
| # Python dependencies | ||
| ADD requirements.txt . |
Check notice
Code scanning / SonarCloud
Prefer COPY over ADD for copying local resources Low
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on a past PR from @stv0g . I made some changes recently and was able to deploy DPsim successfully in Mybinder. This requires to place a new Dockerfile (adapted from the Fedora-based Dockerfile) in the dpsim's root folder. Because this is intended to offer another way of end users to interact with DPsim, I think one important question here is: Should we keep this functionality as part of DPsim's main repo, or should we implement it in a separate repo?