Fix submodule initialization for CIMpp in Dockerfiles. #331
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pipeacosta
requested review from
leonardocarreras
and removed request for
stv0g and
n-eiling
n-eiling
previously approved these changes
Jan 22, 2025
|
@pipeacosta can you also update the repo url? Libcimpp has moved to sogno a long time ago but I forgot to update the path. |
pipeacosta
force-pushed
the
fix-cimpp-docker
branch
2 times, most recently
from
c05d0a7 to
e19628b
Compare
|
The CI is failing because of some caching issue. If you delete the cache and retry it usually works. Maybe rebasing the branch also helps. |
Signed-off-by: Andres Acosta <[email protected]>
Signed-off-by: Andres Acosta <[email protected]>
pipeacosta
force-pushed
the
fix-cimpp-docker
branch
from
e19628b to
1b946a4
Compare
|
I cleared the cache now, let's see if it works |
done |
|
@n-eiling @leonardocarreras Thanks a lot for your support, the CI is working now |
leonardocarreras
approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the building process of CIMpp in the Docker files. Since we are now checking out a specific commit of this library, we need to make sure that the git submodules are updated after the checkout.