Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes perk-based damage mods, adds ablative subdermal armor #5070

Merged
merged 9 commits into from
Mar 11, 2024

Conversation

Xaytan
Copy link
Contributor

@Xaytan Xaytan commented Feb 24, 2024

About The Pull Request

About The Pull Request

Fixes brute and burn damage modifiers from perks.

Adds an alternative version of subdermal armor that reduces burn damage.

Full list of things that were nonfunctional prior to this change

Cow Skin Mutation
Gigantism Mutation
Thick Fur Mutation
Dwarfism Mutation
Revival Sickness
Aulvae Decohesion Syndrome
Nanofiber Muscle Therapy
Natural Armor
Thin Skin
Ra Cht'mant
Monomial Bulwark of Harmony
Ironskin draught


Changelog

🆑
fix: Perk based damage modifiers will now properly apply to damage taken.
fix: Adds ablative subdermal armor.

/:cl:

@Trilbyspaceclone Trilbyspaceclone added Unintended Something isn't working as intended Skill-Issue | Salt PR A PR that was made out of lacking skill or pure rage at a change labels Feb 25, 2024
@Trilbyspaceclone
Copy link
Collaborator

This adds in additional issues
Subdermal armor does infact work

@cdb-is-not-good
Copy link
Collaborator

Don't close PRs for "having issues" without specifying what issues

@Trilbyspaceclone Trilbyspaceclone marked this pull request as draft February 25, 2024 20:37
@benj8560
Copy link
Contributor

I can quote trilby on subdermal armor working just fine as is. Its handled limb by limb making it fully body protection like this from a single implant slot is pretty massive balance wise. It's already quite good.

@Xaytan
Copy link
Contributor Author

Xaytan commented Feb 26, 2024

I can quote trilby on subdermal armor working just fine as is. Its handled limb by limb making it fully body protection like this from a single implant slot is pretty massive balance wise. It's already quite good.

We've already discussed it and tested it. Trilby had told me it wasn't working the other day, but apparently Trilby thinks it's funny to say bugs exist that she knows don't.

The other change in this PR still needs to happen.

@Xaytan Xaytan changed the title Fixes subdermal armor and perk based damage mods Fixes perk-based damage mods, adds ablative subdermal armor Feb 26, 2024
@Xaytan Xaytan marked this pull request as ready for review February 26, 2024 06:40
@cdb-is-not-good
Copy link
Collaborator

I can quote trilby on subdermal armor working just fine as is. Its handled limb by limb making it fully body protection like this from a single implant slot is pretty massive balance wise. It's already quite good.

We've already discussed it and tested it. Trilby had told me it wasn't working the other day, but apparently Trilby thinks it's funny to say bugs exist that she knows don't.

The other change in this PR still needs to happen.

Amazing, simply fantastic.

@Trilbyspaceclone Trilbyspaceclone added Question Further information is requested Bug-Fix Fixes issues Balance Improves on fairness and removed Unintended Something isn't working as intended Skill-Issue | Salt PR A PR that was made out of lacking skill or pure rage at a change labels Feb 28, 2024
@Trilbyspaceclone Trilbyspaceclone added Test Merged A RP that is test merged before added to the code itself and removed Question Further information is requested labels Feb 29, 2024
@cdb-is-not-good cdb-is-not-good removed the Test Merged A RP that is test merged before added to the code itself label Mar 11, 2024
@cdb-is-not-good cdb-is-not-good merged commit fb43f07 into sojourn-13:master Mar 11, 2024
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Balance Improves on fairness Bug-Fix Fixes issues
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants