-
Notifications
You must be signed in to change notification settings - Fork 116
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: improve create-solana-dapp args handling #8
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
beeman
force-pushed
the
beeman/cleaner-snapshots
branch
from
November 9, 2023 15:12
24b31a3
to
f011912
Compare
beeman
force-pushed
the
beeman/args-handling
branch
2 times, most recently
from
November 9, 2023 15:19
a60f42f
to
d0bdf3e
Compare
beeman
force-pushed
the
beeman/args-handling
branch
from
November 9, 2023 16:57
d0bdf3e
to
79500c0
Compare
beeman
force-pushed
the
beeman/args-handling
branch
4 times, most recently
from
November 10, 2023 14:55
97ef26e
to
2e196ef
Compare
nickfrosty
reviewed
Nov 10, 2023
return value | ||
}, | ||
) | ||
.option('--anchor-build', help(`Build the anchor project (default: false)`), false) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This extra false
was printing the extra line on the help menu.
Does not having it set here make the values to not be false by default? Do we need to use the anchor input normalizer to set this default=false?
beeman
force-pushed
the
beeman/args-handling
branch
2 times, most recently
from
November 10, 2023 21:34
7e996a0
to
a9a17ad
Compare
beeman
force-pushed
the
beeman/args-handling
branch
from
November 10, 2023 23:15
f07bcd8
to
8bb93ba
Compare
beeman
force-pushed
the
beeman/args-handling
branch
from
November 10, 2023 23:36
8bb93ba
to
1c22f3a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some improvements of how the args of
create-solana-dapp
are handled.It now supports
name
as a positional argument, sonpx create-solana-dapp@latest my-app
instead ofnpx create-solana-dapp@latest --name my-app
.It's still optional so if it's not provided it will prompt the user.
The second change is that the
--anchor
flag now acceptsnone|counter|hello-world
, merging theanchor
andanchor-template
flags.Some other fixes:
anchor
instead ofprogram
sync-schemas
script passesadditionalProperties: false
tojson-schema-to-typescript
to prevent it from adding a[k: string]: unknown
property to theschema.d.ts
files.The output is currently like this, we'll have to for in and customize some Nx scripts (or make changes upstream) to make the output of the workspace creation completely silent.