SIMD-0194: Deprecate rent exemption threshold #194
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Minor edits / suggestions
buffalojoec
reviewed
Nov 15, 2024
Comment on lines
44
to
45
| Set the value of `DEFAULT_EXEMPTION_THRESHOLD` from `2.0` to `1.0`, and | ||
| deprecate it from the protocol. |
There was a problem hiding this comment.
How do you propose deprecation? I'm curious which one hurts less post-deprecation: changing to 1u64 and preserving the account layout/size, or complete removal, changing the account size.
There was a problem hiding this comment.
We simply stop using it in any SDKs and thus any new programs going forward will be using u64 math, simply omitting the f64 value entirely, but it will remain in the rent account to not break the existing API and will be flagged as deprecated.
Comment on lines
93
to
94
| * Allow users to make the assumption that `2.0` will remain stable and do `u64` | ||
| math themselves. |
There was a problem hiding this comment.
We could stablize this, but imo the field will soon become a misnomer, considering rent collection is being disabled. I think your proposed design makes more sense.
Fix lint
…deprecate-rent-exemption-threshold.md
deanmlittle
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.