Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

code-Update Dockerfile #35731

Closed
wants to merge 1 commit into from
Closed

Conversation

romashka-btc
Copy link

Fix: Sorted package names alphanumerically in Dockerfile

Changes

  • Rearranged the package names in the apt-get install command to be in alphabetical order within each section for better readability and maintainability.

    • Before:

      apt-get install --no-install-recommends -y \
        # basic
        tzdata \
        apt-transport-https \
        sudo \
        build-essential \
        git \
        vim \
        jq \
        ca-certificates \
        curl \
        gnupg \
        lld \
        cmake \
        # docs
        mscgen \
        # solana compiling
        libssl-dev \
        libudev-dev \
        pkg-config \
        zlib1g-dev \
        llvm \
        clang \
        cmake \
        make \
        libprotobuf-dev \
        protobuf-compiler \
    • After:

      apt-get install --no-install-recommends -y \
        # basic
        apt-transport-https \
        build-essential \
        ca-certificates \
        curl \
        git \
        gnupg \
        jq \
        lld \
        sudo \
        tzdata \
        vim \
        # docs
        mscgen \
        # solana compiling
        clang \
        cmake \
        libprotobuf-dev \
        libssl-dev \
        libudev-dev \
        llvm \
        make \
        pkg-config \
        protobuf-compiler \
        zlib1g-dev \

Purpose

  • Improved code clarity and consistency by sorting package names alphanumerically within each section.
  • Retained section comments (# basic, # docs, # solana compiling) for better understanding.

Copy link
Collaborator

@anza-team anza-team left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the contribution! This repository is no longer in use. Please re-open this pull request in the agave repo: https://github.com/anza-xyz/agave

@anza-team anza-team closed this Dec 24, 2024
@mergify mergify bot added community Community contribution need:merge-assist labels Dec 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
community Community contribution need:merge-assist
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants