Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refuse to honour RSFNC for a RESV nick #329

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

jesopo
Copy link
Member

@jesopo jesopo commented Apr 15, 2022

No description provided.

@dwfreed
Copy link
Member

dwfreed commented Apr 15, 2022

This breaks keeping a RESV for Guest* so that the only way a person can have a guest nick is via services. OFTC currently has such a RESV, though I suspect part of our reasoning is that our guest nicks are sequential and we do not have SAVE, so a determined attacker could kill a guesting client by colliding with their nick change.

@jesopo
Copy link
Member Author

jesopo commented Apr 15, 2022

we could solve that by having 2 kinds of RSFNC. one that is expected to sometimes fail and one that should never fail, and you'd use the former for any user-supplied nickname

@dwfreed
Copy link
Member

dwfreed commented Apr 15, 2022

Atheme already allows differentiating between a regain and a force change via the fnc_sts handler; FNC_REGAIN is the type value for regain, and FNC_FORCE is the type value for force changes. If we pursue that route, I think RSFNC should remain the FNC_FORCE handler, and we could add something like ENCAP REGAIN for the FNC_REGAIN handler, which would require compliance with all applicable nick rules, just like NICK

@jesopo
Copy link
Member Author

jesopo commented Jul 25, 2022

atheme work done here atheme/atheme#864 so now we can think about how this should look over the wire

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants