Add secrets.json #2
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This augments the `environment_secrets` repository rule to also emit `secrets.json` alongside `secrets.bzl`. This allows application code to parse the JSON file rather than the skylark file to retrieve all secrets. Alternatively, the user could list the secrets in `environment_secrets`, duplicate them in the `load()` statement, and duplicate them in some sort of template expansion genrule to create a file to be used at runtime. NOTE: This also adds the latest version of skylib because it wasn't available otherwise.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This augments the
environment_secretsrepository rule to also emitsecrets.jsonalongsidesecrets.bzl. This allows application code toparse the JSON file rather than the skylark file to retrieve all
secrets. Alternatively, the user could list the secrets in
environment_secrets, duplicate them in theload()statement, andduplicate them in some sort of template expansion genrule to create a
file to be used at runtime.
NOTE: This also adds the latest version of skylib because it wasn't
available otherwise.