Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PHPUnit 9 → 10 #1144

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Conversation

thomascorthals
Copy link
Member

@thomascorthals thomascorthals commented Jan 20, 2025

Major changes affecting us:

  • setUpBeforeClass()/tearDownAfterClass() can no longer perform assertions. Tests of correct configuration have been moved to separate test functions.
  • Changes in mocks necessitate a different approach, a.o. when testing traits.
  • Data providers always have to be declared static.

@thomascorthals thomascorthals marked this pull request as draft January 20, 2025 12:06
@thomascorthals
Copy link
Member Author

Looks like I broke the codecov integration. Converting to draft for now.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.72%. Comparing base (9cdf3dd) to head (9606926).
Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1144      +/-   ##
==========================================
- Coverage   97.75%   97.72%   -0.04%     
==========================================
  Files         400      403       +3     
  Lines       10524    10578      +54     
==========================================
+ Hits        10288    10337      +49     
- Misses        236      241       +5     
Flag Coverage Δ
unittests 97.72% <ø> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant