Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-90480 Add publish of autoinstrumentation image #481

Merged
merged 27 commits into from
Jan 27, 2025

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Jan 8, 2025

Adds manual workflow to build and publish autoinstrumentation-python to Docker images and ghcr.io packages.

Installs APM Python from PyPI, version specified in new requirements-nodeps.txt. Borrows from OTel's builds which do not opentelemetry-bootstrap. Instead, they do custom pip installation of several opentelemetry-instrumentation-* to a specific directory that can be copied into a Pod and pointed to for auto-instrumentation. Also avoids installing grpcio!

@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-90480-add-operator-image branch from 3a53d76 to 7e8619d Compare January 9, 2025 00:00
@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-90480-add-operator-image branch from dd40f1b to ace4176 Compare January 13, 2025 18:52
@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-90480-add-operator-image branch from 8a995ce to 726b405 Compare January 13, 2025 21:50
@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-90480-add-operator-image branch from e620ee1 to 78fe027 Compare January 22, 2025 21:28
@tammy-baylis-swi tammy-baylis-swi force-pushed the NH-90480-add-operator-image branch from 92b8f1b to 25c1a84 Compare January 23, 2025 01:29
@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review January 23, 2025 01:34
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner January 23, 2025 01:34
Comment on lines +39 to +45
- name: Login to GitHub Package Registry
uses: docker/login-action@v3
if: ${{ github.event_name == 'push' }}
with:
registry: ghcr.io
username: ${{ github.repository_owner }}
password: ${{ secrets.GITHUB_TOKEN }}

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this necessary for Docker Hub ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tammy-baylis-swi tammy-baylis-swi merged commit 405c8fa into main Jan 27, 2025
17 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-90480-add-operator-image branch January 27, 2025 19:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants