Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NH-100646 _get_extension now based on if Legacy, not if Lambda #503

Conversation

tammy-baylis-swi
Copy link
Contributor

@tammy-baylis-swi tammy-baylis-swi commented Feb 1, 2025

Note: This will merge into epic feature branch NH-79205-otlp-by-default

_get_extension_components is now based on SW_APM_LEGACY false/true, instead of "is lambda". I'm keeping two separate try-except for now around import of solarwinds_apm.extension.oboe then import of OboeAPI and options, in case of upcoming updated extension builds. Also updates str(ApmConfig) debug helper to include OboeAPI.

@tammy-baylis-swi tammy-baylis-swi marked this pull request as ready for review February 4, 2025 18:08
@tammy-baylis-swi tammy-baylis-swi requested a review from a team as a code owner February 4, 2025 18:08
Copy link
Contributor

@cheempz cheempz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tammy-baylis-swi tammy-baylis-swi merged commit b3c94da into NH-79205-otlp-by-default Feb 5, 2025
15 checks passed
@tammy-baylis-swi tammy-baylis-swi deleted the NH-100646-get-extension-legacy-condition branch February 5, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants