NH-100646 Create init event if Legacy, instead of if not-Lambda #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
commented
Feb 3, 2025
Comment on lines
-811
to
-814
| if apm_config.is_lambda: | ||
| logger.debug("Skipping init event in lambda") | ||
| return None | ||
|
|
There was a problem hiding this comment.
Removed this because _configure is the only caller of this _create_init_event, and the former checks if legacy already
tammy-baylis-swi
commented
Feb 3, 2025
Comment on lines
-24
to
-27
| result = test_configurator._create_init_event( | ||
| mock_extension.Reporter, | ||
| mock_apmconfig_enabled_is_lambda, | ||
| ) |
There was a problem hiding this comment.
Removed this test because function doesn't do this check anymore (see comment).
raphael-theriault-swi
approved these changes
Feb 4, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This will merge into epic feature branch
NH-79205-otlp-by-defaultChanges APM Python Configurator to create APM-proto init event only if running in Legacy mode. Previously the condition was "if not Lambda".