-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
NH-98561 Update integration tests #510
Open
tammy-baylis-swi
wants to merge
19
commits into
NH-79205-otlp-by-default
Choose a base branch
from
NH-98561-update-integration-tests
base: NH-79205-otlp-by-default
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
NH-98561 Update integration tests #510
tammy-baylis-swi
wants to merge
19
commits into
NH-79205-otlp-by-default
from
NH-98561-update-integration-tests
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tammy-baylis-swi
force-pushed
the
NH-98561-update-integration-tests
branch
from
February 6, 2025 18:06
31f96cd
to
9e76a56
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note: This will merge into epic feature branch
NH-79205-otlp-by-default
.Updates the APM Python integration/functional tests so that OTLP metrics/logs generation and export are checked when enabled. Overall changes:
legacy
subdir, and they're the same besides some var renames.otlp
subdir. They test the same scenarios aslegacy
but with different liboboe mocks and added OTLP metrics, logs assertions.TestBaseSw
class (with a much shorter name), extended byTestBaseSwLegacy
andTestBaseSwOtlp
for their respective tests.As previously, these tests do partial, manual loading of APM Python otel components so that traces/metrics/logs can be captured by the
InMemory*
test utils and checked there, instead of actual export to backend/file/etc.Please let me know if any questions/comments!