Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade playground to new worker import syntax #88

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

timotius02
Copy link

@timotius02 timotius02 commented Mar 20, 2022

#86

@amoutonbrady
Copy link
Member

Thanks! This is looking good. Unfortunately, I'm seeing a bunch of errors :/

image

Not entirely sure where this is coming from

@timotius02
Copy link
Author

Yeah it's looking like its a more complicated migration than I thought, specifically importing from node_modules. I'll be asking around the Vite discussion boards if anyone has any idea on this, but this is probably out of the scope of my current understanding.

@amoutonbrady
Copy link
Member

I figured this wouldn't be an easy task. We also need to think how and if this can affect the library mode (solid-repl).
I'll put this PR in draft for the moment while you (or anyone else) investigate the matter if you don't mind :)

@milomg
Copy link
Member

milomg commented Jun 18, 2022

I would guess the issue is that vite can't statically analyze createWorker and so throws an error? Does that match what you've discovered? Also, this will not affect library mode because it only changes the /playground folder (but we should make sure it works in both dev and prod)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants