Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed vitest templates #115

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Conversation

mustevenplay
Copy link

'registerNodeLoader' on true wouldn't let the tests run successfully, not in this version, nor in newer. It also is necessary to have it explicitly on false, or else, the tests wouldn't work either.

Besides it doesn't log any warning on dependency duplicity, like it does in other cases, so I also removed the comments that said that.

'registerNodeLoader' on true wouldn't let the tests run successfully, not in this version, nor in newer. It also is necessary to have it explicitly on false, or else, the tests wouldn't work either.

Besides it doesn't log any warning on dependency duplicity, like it does in other cases, so I also removed the comment that said that.
@awhitford
Copy link

I tried adjusting the registerNodeLoader to false, but it did not resolve #135.

@atk
Copy link
Contributor

atk commented Dec 29, 2023

This is because vite-plugin-solid overwrites a few settings.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants