Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve tests for vitest by fully utilizing testing lib api #66

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

chris-czopp
Copy link

  • changed tests to utilize more of the testing library API, things like: expect(screen.getByRole('checkbox')).not.toBeChecked();
  • upgraded vitest template modules
  • added .idea/ to .gitignore

In the future I'd like to add API mocking too.

@amoutonbrady amoutonbrady changed the base branch from master to main June 17, 2023 08:10
@amoutonbrady
Copy link
Member

Hey, sorry for the delay it took me to evaluate this MR, life's been in the way...
I reckon I don't know that much about vitest and all the testing framework.
Would you mind pulling the latest changes in the repo and adapting your MR to it? 🙏🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants