Relax Ruby version requirement; get CI passing #23
+48
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
2 times, most recently
from
0a7d63c to
19225c7
Compare
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
from
524cf3e to
325280b
Compare
benjaminwil
changed the title
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
from
325280b to
dc61444
Compare
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
2 times, most recently
from
bcde30a to
78e668f
Compare
In tests. We'd like to use it for the feature test in this extension.
Ruby 2 has been end-of-lifed. There doesn't seem to be a specific reason for this Ruby version requirement, so let's relax it.
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
2 times, most recently
from
2f38dcd to
45e9064
Compare
We can depend on `solidus_dev_support` to do this for us. We did a `bundle update solidus_dev_support`, too.
On CI this feature test was flaky. It seems like not all product pages were being visited consistently; the errors were about "Jersey" being missing from the expected page body text.
There is no reason for us to require this as a dependency. `sassc` is also a deprecated way of compiling SCSS to CSS.
In CI we received this error, causing the test run to fail early:
Zeitwerk::NameError: expected file /home/circleci/project/app/overrides/add_recently_viewed_products.rb
to define constant AddRecentlyViewedProducts, but didn't
/home/circleci/project/spec/dummy/config/environment.rb:5:in `<top (required)>'
Co-Authored-By: Adam Mueller <[email protected]>
This change: - Ensures that browser tools for running feature tests are explicitly available. - Ensures that all required executors use Ruby 3. (Ruby 2 is now EOL.)
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
from
45e9064 to
0da1c9d
Compare
This causes test runs on CI to fail with: Failure/Error: ActiveStorage::Current.host = 'https://www.example.com' NoMethodError: undefined method `host=' for #<ActiveStorage::Current:0x00007f12e8d2bbb0 @attributes={}> # ./spec/spec_helper.rb:28:in `block (2 levels) in <top (required)>'
benjaminwil
force-pushed
the
ruby-version-requirement-bump
branch
from
99d7846 to
921d6e7
Compare
benjaminwil
changed the title
MadelineCollier
approved these changes
Sep 17, 2024
tvdeyen
approved these changes
Sep 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ruby 2.7 has been end-of-lifed, and Solidus no longer supports Ruby 2, either. We should relax the Ruby version constraints for this extension. There doesn't seem to be a specific reason for the constraint as it was written.