Restore Puma & SQLite dependency to correct state #6082
+2
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue with capybara that originally caused the change to the main branch of the puma repo has been fixed and solidus should return on the Puma release cycle.
github-actions
bot
added
the
changelog:repository
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #6082 +/- ##
==========================================
+ Coverage 89.33% 89.58% +0.24%
==========================================
Files 730 801 +71
Lines 16462 18275 +1813
==========================================
+ Hits 14706 16371 +1665
- Misses 1756 1904 +148 ☔ View full report in Codecov by Sentry. |
It would be great if you 4 adhere to same standard that you ask from my two guys and document things properly. |
…recent versions Not required anymore. solidusio#5727
fthobe
changed the title
fthobe
changed the title
jarednorman
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixes two dependency pinnings:
Due to changes in Puma Capybara failed. The solution was to pin Puma to the development branch. Given that the issue has been resolved, I restored the gemfile to a stable puma release.
original reason to pin sqlite:
Issue has been solved in the meantime.
Fixes #6081
Checklist
Check out our PR guidelines for more details.
The following are mandatory for all PRs:
The following are not always needed: