-
-
Notifications
You must be signed in to change notification settings - Fork 124
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Merge pull request from GHSA-xm34-v85h-9pg2
Fix account takeover through CSRF attack
- Loading branch information
Showing
2 changed files
with
48 additions
and
1 deletion.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,42 @@ | ||
# frozen_string_literal: true | ||
|
||
RSpec.feature 'User update', type: :request do | ||
context 'CSRF protection' do | ||
%i[exception reset_session null_session].each do |strategy| | ||
# Completely clean the configuration of forgery protection for the | ||
# controller and reset it after the expectations. However, besides `:with`, | ||
# the options given to `protect_from_forgery` are processed on the fly. | ||
# I.e., there's no way to retain them. The initial setup corresponds to the | ||
# dummy application, which uses the default Rails skeleton in that regard. | ||
# So, if at some point Rails changed the given options, we should update it | ||
# here. | ||
around do |example| | ||
controller = Spree::UsersController | ||
old_allow_forgery_protection_value = controller.allow_forgery_protection | ||
old_forgery_protection_strategy = controller.forgery_protection_strategy | ||
controller.skip_forgery_protection | ||
controller.allow_forgery_protection = true | ||
controller.protect_from_forgery with: strategy | ||
|
||
example.run | ||
|
||
controller.allow_forgery_protection = old_allow_forgery_protection_value | ||
controller.forgery_protection_strategy = old_forgery_protection_strategy | ||
end | ||
|
||
it "is not possible to take account over with the #{strategy} forgery protection strategy" do | ||
user = create(:user, email: '[email protected]', password: 'password') | ||
|
||
post '/login', params: "spree_user[email][email protected]&spree_user[password]=password" | ||
begin | ||
put '/users/123456', params: 'user[email][email protected]' | ||
rescue | ||
# testing that the account is not compromised regardless of any raised | ||
# exception | ||
end | ||
|
||
expect(user.reload.email).to eq('[email protected]') | ||
end | ||
end | ||
end | ||
end |