Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#401Images vanishing #403

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

#401Images vanishing #403

wants to merge 1 commit into from

Conversation

magpieuk
Copy link
Contributor

Summary

Fixes #401

Images disappear when running in production mode with caching enabled.

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This solution doesn't work for other active storage backends. It only fixes it for local, which you probably shouldn't be using.

Copy link
Member

@jarednorman jarednorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was mistaken. According to the docs this solution is supposed to generate a permanent URL. I'm curious as to how that would work backends like S3, but this seems like right approach.

@fthobe
Copy link
Contributor

fthobe commented Jan 8, 2025

@jarednorman we are installing the first prod similar env this week and can try it before anybody merges this.

@fthobe
Copy link
Contributor

fthobe commented Jan 8, 2025

@magpieuk is this a permanent setup for you or will you add any external media hosting in production like S3?

@fthobe
Copy link
Contributor

fthobe commented Jan 13, 2025

@magpieuk i will test it today. Can you tell me more about the environment that produced the problems?

@boomer196
Copy link

This won't work if you have Solidus image_attachment_module configured to use Spree::Image::PaperclipAttachment. There is no variant method defined on that class.

@fthobe
Copy link
Contributor

fthobe commented Feb 10, 2025

I am not sure if paperclip is still supported. I think that's something to be asked on slack and to be aligned on docs afterwards.

@jarednorman
Copy link
Member

Paperclip is still supported.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Storefront images disapear
4 participants