Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Metrics for test cases #5

Merged
merged 8 commits into from
Dec 19, 2024
Merged

Metrics for test cases #5

merged 8 commits into from
Dec 19, 2024

Conversation

ryanrolds
Copy link
Collaborator

  • Added testcase-level metrics
  • Added histogram to testcases and testsuites
  • Reduced the labels/attributes added to metrics (reduce cardinality)

@ryanrolds ryanrolds marked this pull request as ready for review December 19, 2024 00:21
sheidkamp
sheidkamp reviewed Dec 19, 2024
View reviewed changes
Copy link

@sheidkamp sheidkamp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looking good, just a couple of thoughts

@ryanrolds ryanrolds requested a review from sheidkamp December 19, 2024 16:13
@ryanrolds ryanrolds merged commit 5d5e141 into solo-ci Dec 19, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sheidkamp sheidkamp sheidkamp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ryanrolds @sheidkamp