Added --add-attrbitues flag and brings in recent changes to main #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Updating OTEL client * Updated OTEL client * Fixing issue with error about exporting being shutdown * Removed some commented code * Fixed newline causing test to fail * Updating Go version * Updating Go version * Updating Go version * Removed port debugging output
Bumps [github.com/joshdk/go-junit](https://github.com/joshdk/go-junit) from 0.0.0-20210226021600-6145f504ca0d to 1.0.0. - [Release notes](https://github.com/joshdk/go-junit/releases) - [Commits](https://github.com/joshdk/go-junit/commits/v1.0.0) --- updated-dependencies: - dependency-name: github.com/joshdk/go-junit dependency-type: direct:production update-type: version-update:semver-major ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
* chore: use non-deprecated API * chore: bump tc-go to latest release * chore: use testcontainers-go newer APIs * chore: use testing library as much as possible * chore: use filepath * fix: do not swallow errors * chore: use testify's require * chore: use testing library * chore: use testing library as much as possible * chore: better test names * chore: add helper * chore: rename helper function * chore: use wait for file * chore: use docker compose binary * chore: use testdata * fix: reset state inn test
* fix: create span processor with batch size * chore: make batch size configurable using a command-line flag * chore: use testing library to set up env vars in tests * chore: extract creation of test containers to a method * fix: swap json objects parsing * fix: swap back * chore: increase batch size in tests
Bumps [gotest.tools/gotestsum](https://github.com/gotestyourself/gotestsum) from 1.8.2 to 1.12.0. - [Release notes](https://github.com/gotestyourself/gotestsum/releases) - [Commits](gotestyourself/gotestsum@v1.8.2...v1.12.0) --- updated-dependencies: - dependency-name: gotest.tools/gotestsum dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…ya#94) * deps: bump github.com/go-git/go-git/v5 from 5.4.2 to 5.12.0 Bumps [github.com/go-git/go-git/v5](https://github.com/go-git/go-git) from 5.4.2 to 5.12.0. - [Release notes](https://github.com/go-git/go-git/releases) - [Commits](go-git/go-git@v5.4.2...v5.12.0) --- updated-dependencies: - dependency-name: github.com/go-git/go-git/v5 dependency-type: direct:production update-type: version-update:semver-minor ... Signed-off-by: dependabot[bot] <[email protected]> * fix: use proper target branch name in tests --------- Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Manuel de la Peña <[email protected]>
* Updating OTEL client * Updated OTEL client * Fixed newline causing test to fail * Adding an allow list for properties * Added default value to make it cleaner * Removed debug code * Removed port debugging output * Improved test reliability * Switch to waiting for port * Tidy the mods
ryanrolds
changed the title
nfuden
approved these changes
Dec 24, 2024
There was a problem hiding this comment.
Now this is going be a real annoying request. Can we first fastforward our fork and then squash all your commits into one squashed commit?
Also happy to not do that if its too painful.
I do like the attributes and how it lets you know that you are passing something bad in if it doesnt follow the right semantics!
|
We will be moving off this branch once upstream is caught up. So, lets not worry about it being perfect. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In our CI pipelines we call the same tests several times in slightly different contexts. We need to be able to pass through labels to differentiate between suites/tests.
Added a Make target for running tests.