Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] F-strings are not necessary if there is no placeholder #2307

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Jan 25, 2025

Description

This PR makes the code conformant with F541.

To-Dos

  • I have created tests for any new or updated functionality. (not relevant)
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@vil02 vil02 force-pushed the fix_f_strings_with_missing_placeholders branch 2 times, most recently from 8af9ea6 to 87a35fc Compare January 25, 2025 20:42
@vil02 vil02 changed the title [style] F-strings are not necessary if there is not placeolder [style] F-strings are not necessary if there is not placeholder Jan 25, 2025
@vil02 vil02 force-pushed the fix_f_strings_with_missing_placeholders branch from 87a35fc to f4fba6e Compare January 25, 2025 20:43
@vil02 vil02 changed the title [style] F-strings are not necessary if there is not placeholder [style] F-strings are not necessary if there is no placeholder Jan 25, 2025
@vil02 vil02 marked this pull request as ready for review January 25, 2025 20:50
@aquamatthias aquamatthias merged commit 13a692f into someengineering:main Jan 27, 2025
@vil02 vil02 deleted the fix_f_strings_with_missing_placeholders branch January 27, 2025 07:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants