Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[style] Use is to compare types #2317

Merged
merged 1 commit into from
Feb 20, 2025
Merged

Conversation

vil02
Copy link
Contributor

@vil02 vil02 commented Feb 16, 2025

Description

This PR makes the code conformant with E721.

Similar to #2314.

To-Dos

  • I have created tests for any new or updated functionality. (not relevant)
  • I ran tox successfully.

Code of Conduct

By submitting this pull request, I agree to follow the code of conduct.

@vil02 vil02 marked this pull request as ready for review February 16, 2025 12:50
Copy link
Member

@lloesche lloesche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you @vil02

@lloesche lloesche merged commit 431a490 into someengineering:main Feb 20, 2025
26 checks passed
@vil02 vil02 deleted the resolve_E721 branch February 27, 2025 21:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants