Prepend JMSDiExtraBundle configuration making FosRestBundle/NelmioApiDocBundle optional #829
Conversation
| // Blacklist all API controllers when using JMSDiExtraBundle without NelmioApiDocBundle or FOSRestBundle. API | ||
| // controllers use annotations and would be warmed, throwing an exception. | ||
| if (isset($bundles['JMSDiExtraBundle']) && | ||
| (!isset($bundles['NelmioApiDocBundle']) || !isset($bundles['FOSRestBundle']))) { |
There was a problem hiding this comment.
I think this is equivalent to !isset($bundles['NelmioApiDocBundle'], $bundles['FOSRestBundle'])
There was a problem hiding this comment.
I'll check and report back, never used more than one argument.
gremo
changed the title
There was a problem hiding this comment.
Can you please add a test, using this bundle?
https://github.com/matthiasnoback/SymfonyDependencyInjectionTest
Thank you!
|
@gremo could you please finalize this PR? |
…DocBundle optional
|
@OskarStark I rebased this PR as a starting point. How should I finalize this? I still think that the problem is described schmittjoh/JMSDiExtraBundle#269 but no one cares, I you can help with that PR it would be great. |
|
So @OskarStark this is a workaround because no one seems to care the PR that I opened to JMSDiExtraBundle. How we should proceed? |
|
So @greg0ire I think we can close this thanks to schmittjoh/JMSDiExtraBundle#270? |
I am targetting this branch, because this PR make possible to use JMSDiExtra bundle without
FosRestBundleandNelmioApiDocBundle.Closes #686
Changelog