Add ability to configure 'forceBasicAuth' for docker registries #31
Conversation
| * @param v1Enabled Whether or not this Repository supports Docker V1 format | ||
| * @param strictContentTypeValidation Whether or not the Repository should enforce strict content types | ||
| * @param writePolicy The {@link WritePolicy} for the Repository | ||
| * @param forceBasicAuth whether or not this Repository should support anonymous pull |
There was a problem hiding this comment.
This comment is not entirely true.
forceBasicAuth=true means use BASIC auth.
forceBasicAuth=false means use bearer token auth.
False is required for anonymous access but it doesn't guarantee it, also you could configure the permissions so that it isn't just "pull" specific. How about something like "whether to force basic auth (false is required to enable token auth which can be used for anonymous access)"
There was a problem hiding this comment.
@jlstephens89 thanks for remark. Fixed
|
@jlstephens89 Hi! could you approve this PR or any other comments will be? |
|
Hi all! When this MR will be merged? Is some due date exists ? |
|
Thanks for the contribution @bourd0n, before we can merge could I ask you to sign the Sonatype Contributor License Agreement |
|
@doddi yes, i sign CLA |
|
Guys, any new on this MR? This is really usefull stuff for us and we're waiting the feature eagerly. |
|
Working on getting this imported internally today fellas! Sorry for the wait! |
|
Closing as this is now merged internally. |
|
This is just conjecture but I assume when this is released formally it'll be for 3.14 (next minor release). |
|
@joedragons , actually this would filter out the next time we do a synch from our internal repo to public, likely Sunday. As for it being in a released downloadable product, you are correct, but someone can assumedly build the source and see it in there as of Monday. |
|
Hello, |
|
@micw I don't think we're going to unmerge to add further stuff. Do you mind filing a ticket on issues.sonatype.com; we will keep in mind with other issues. Or PRs welcome. |
|
I've created a follow-up PR at #41 |
No description provided.