fix for https://github.com/sonic-net/DASH/issues/454 #455
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eni was not very descriptive and one could assume it is the eni object id, updated the name to clearly specify it is the eni mac
|
looks like The dash sonic hld is moving to sonic repo while DASH repo will link to the sonic one as reference, so I wonder if we could make the change there. both prince and i should be able to help sign off: https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md. and here is the PR that I am refering to: #447. |
prsunny
approved these changes
Oct 31, 2023
r12f
approved these changes
Oct 31, 2023
prsunny
requested changes
Oct 31, 2023
There was a problem hiding this comment.
@mgheorghe , changes lgtm, but can you make the change here - https://github.com/sonic-net/SONiC/blob/master/doc/dash/dash-sonic-hld.md.
|
do not merge yet or cancel |
|
canceling, was a misunderstanding |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
eni was not very descriptive and one could assume it is the eni object id, updated the name to clearly specify it is the eni mac
fixes #454