Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Design document for L2 ACL table support #1165

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

ArthiGovindaraj
Copy link

L2 ACL table with L2 match fields in Ethernet and vlan header are not supported in existing design. This design document gives the proposal for supporting the same.

Associated pull request for the proposed design:
sonic-swss: sonic-net/sonic-swss#2554
acl-loader: sonic-net/sonic-utilities#2516
schema update only : sonic-net/sonic-mgmt-common#66

VLAN | uint16_t | Decimal values from 1-4094
VLAN_PCP | uint8_t | Decimal value or value/mask [0..7 (or) 0..7/0..7]
VLAN_DEI | uint8_t | Decimal value of 0 or 1 [0..1]

Copy link

@marvellgit marvellgit Nov 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please consider add ethernet type match
Ethernet II
IEEE 802.3 CSMA/CD
IEEE 802.3 CSMA/CD LLC
IEEE 802.3 with SNAP

@bluecmd
Copy link

bluecmd commented Jan 17, 2024

@ArthiGovindaraj Nice work, do you have any idea if this can be approved and included?

@ArthiGovindaraj
Copy link
Author

@ArthiGovindaraj Nice work, do you have any idea if this can be approved and included?

@bluecmd, the design and code changes were submitted long back. Waiting for any inputs. So far, there has been no approval.
Associated pull request for the proposed design:
sonic-swss: sonic-net/sonic-swss#2554
acl-loader: sonic-net/sonic-utilities#2516
schema update only : sonic-net/sonic-mgmt-common#66

@bluecmd
Copy link

bluecmd commented Jan 18, 2024

@ArthiGovindaraj I know the frustration. I've had luck getting my changes in if I joined the triage meeting (every other Wednesday) and ask for a review. Maybe try that?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants