Remove UpdateGraphService feature #18330
Conversation
qiluo-msft
requested review from
yxieca,
vaibhavhd,
stepanblyschak and
ben-gale
|
@simone-dell @MichelMoriniaux Could you also help review? #Closed |
| @@ -21,9 +21,6 @@ $(DOCKER_EVENTD)_INSTALL_DEBS = $(PYTHON3_SWSSCOMMON) | |||
| $(DOCKER_EVENTD)_VERSION = 1.0.0 | |||
| $(DOCKER_EVENTD)_PACKAGE_NAME = eventd | |||
|
|
|||
| $(DOCKER_DHCP)_SERVICE_REQUIRES = updategraph | |||
There was a problem hiding this comment.
(DOCKER_DHCP)_SERVICE_REQUIRES in this makefile does not make any sense, and it should be (DOCKER_EVENTD)_xxx.
I guess this is a copy-and-paste error.
There was a problem hiding this comment.
@zbud-msft Could you review here?
There was a problem hiding this comment.
Agreed this should not be in docker-eventd.mk, thanks for fix
| @@ -21,9 +21,6 @@ $(DOCKER_EVENTD)_INSTALL_DEBS = $(PYTHON3_SWSSCOMMON) | |||
| $(DOCKER_EVENTD)_VERSION = 1.0.0 | |||
| $(DOCKER_EVENTD)_PACKAGE_NAME = eventd | |||
|
|
|||
| $(DOCKER_DHCP)_SERVICE_REQUIRES = updategraph | |||
| $(DOCKER_DHCP)_SERVICE_AFTER = database | |||
There was a problem hiding this comment.
Same issue, we should not modify $(DOCKER_DHCP)_SERVICE_AFTER in this makefile
|
In this PR description, could you add a table of all the code PRs related? I see 3 already. #Closed |
Updated. |
|
/azpw run Azure.sonic-buildimage |
|
/AzurePipelines run Azure.sonic-buildimage |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Why I did it
Remove UpdateGraphService feature from sonic image. The goal is to simplify the bootup process.
Related PRs:
Work item tracking
How I did it
Remove updategraph service and updategraph script.
Update all related services, replace updategraph.service with config-setup.service.
How to verify it
Build and install new image, load minigraph and check all the services.
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)