[docker-ptf]: CI change to publish docker-ptf image to the docker registry #20528
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
opcoder0
requested review from
wangxin,
liushilongbuaa,
yutongzhang-microsoft and
xwjiang-ms
azure-pipelines.yml
Outdated
| @@ -52,6 +52,8 @@ variables: | |||
| stages: | |||
| - stage: BuildVS | |||
| pool: sonicbld-1es | |||
| variables: | |||
There was a problem hiding this comment.
azure-pipelines.yml don't need this Variable Group
official-build.yml need this.
| @@ -58,9 +58,23 @@ jobs: | |||
| displayName: 'Make configure' | |||
| postSteps: | |||
| - script: | | |||
| BUILD_REASON=$(Build.Reason) | |||
| if [[ "$BUILD_REASON" != "PullRequest" && "$GROUP_NAME" == "vs" ]] | |||
There was a problem hiding this comment.
Azure.sonic-buildimage.official.vs
Please use pipeline name in condition. Only this pipeline need the step.
Publish to docker registry only for this pipeline
| mkdir -p $(Build.ArtifactStagingDirectory)/target | ||
| mv target/* $(Build.ArtifactStagingDirectory)/target/ | ||
| displayName: Copy Artifacts | ||
| displayName: Publish to Docker Registry and Copy Artifacts |
There was a problem hiding this comment.
you need add something like this
env:
REGISTRY_PASSWD: $(ABC)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Changes to
docker-ptfDockerfile don't get automatically published to the docker registry accessed by the community. This PR addresses the issue.Work item tracking
How I did it
Modified the
postStepsphase inazure-pipelines-image-template.ymlto invoke the script to pushdocker-ptfimage to the docker registry. The push is applicable to build branches (master,202305,202311etc.) and not feature branches.How to verify it
TBD
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Not applicable.
Description for the changelog
[docker-ptf]: CI change to publish docker-ptf image to the public/community docker registry
Link to config_db schema for YANG module changes
Not applicable
A picture of a cute animal (not mandatory but encouraged)