Optimze ACL Table/Rule notification handling #5621
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to loop pop() until empty to consume all the data in a batch This wau we prevent multiple call to iptable updates Signed-off-by: Abhishek Dosi <[email protected]>
jleveque
previously approved these changes
Oct 14, 2020
qiluo-msft
reviewed
Oct 14, 2020
files/image_config/caclmgrd/caclmgrd
Outdated
| # Check ACL Rule notification and make sure Rule point to ACL Table which is Controlplane | ||
| else: | ||
| acl_table = key.split(acl_rule_table_seprator)[0] | ||
| if self.config_db_map[namespace].get_table(self.ACL_TABLE)[acl_table]["type"] == self.ACL_TABLE_TYPE_CTRLPLANE: |
There was a problem hiding this comment.
[](start = 102, length = 1)
Use only one space
There was a problem hiding this comment.
Signed-off-by: Abhishek Dosi <[email protected]>
jleveque
approved these changes
Oct 14, 2020
qiluo-msft
approved these changes
Oct 14, 2020
abdosi
added a commit
that referenced
this pull request
Oct 14, 2020
* Optimze ACL Table/Rule notifcation handling to loop pop() until empty to consume all the data in a batch This wau we prevent multiple call to iptable updates Signed-off-by: Abhishek Dosi <[email protected]> * Address review comments Signed-off-by: Abhishek Dosi <[email protected]>
|
Do you have performance test result? |
@qiluo-msft Also there was no delay in notification and all notification were available in one batch of loop. I did not measure in time perspective. |
santhosh-kt
pushed a commit
to santhosh-kt/sonic-buildimage
that referenced
this pull request
Feb 25, 2021
* Optimze ACL Table/Rule notifcation handling to loop pop() until empty to consume all the data in a batch This wau we prevent multiple call to iptable updates Signed-off-by: Abhishek Dosi <[email protected]> * Address review comments Signed-off-by: Abhishek Dosi <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What I did:
Optimize ACL Table/Rule notification handling
to loop pop() until empty to consume all the data in a batch
This way we prevent multiple call to iptable updates
- How to verify it
Loaded (sudo acl-loader update full acl.json) with 100 rules and verified all the set notification are batch together in one update to iptables .
Similarly (sudo acl-loader delete) batch all del operation in one update.