Add rust implementation of container Python script #38
+1,104
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This handles most use cases for local containers. For Kubernetes containers, there's very limited handling in the start function, and pretty much nothing else. Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
Hi Sai, looks like it is hitting CI errors. Do you mind to help take a look? |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
r12f
reviewed
Feb 1, 2025
| [dependencies] | ||
| bollard = { version = "0.17.1", features = ["chrono"] } | ||
| chrono = "0.4.38" | ||
| enumset = "1.1.5" |
There was a problem hiding this comment.
Will be better to move these dependencies to workspace root.
| bollard = { version = "0.17.1", features = ["chrono"] } | ||
| chrono = "0.4.38" | ||
| enumset = "1.1.5" | ||
| futures-util = "0.3.30" |
There was a problem hiding this comment.
0.3 will be good enough. The last minor version can be ignored, since we have the lock file and will help with upgrade.
|
|
||
| // DB field names | ||
| //const FEATURE_TABLE: &str = "FEATURE"; | ||
| const SET_OWNER: &str = "set_owner"; |
There was a problem hiding this comment.
Maybe better to add a prefix to specify these are db fields.
crates/container/src/main.rs
Outdated
|
|
||
| fn set_label(db_connections: &DbConnections, _feature: &str, _create: bool) { | ||
| if db_connections.remote_ctr_enabled { | ||
| todo!(); |
crates/container/src/main.rs
Outdated
| } | ||
|
|
||
| let rt = tokio::runtime::Builder::new_current_thread() | ||
| .enable_all() |
There was a problem hiding this comment.
Looks like we can use async_main to simplify the code. Is this delayed block_on intentional?
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
Signed-off-by: Saikrishna Arcot <[email protected]>
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a rust implementation of the
containerscript in the SONiC image. This script is primarily responsible for starting, waiting on, and stopping containers.In the case of local containers, this script is basically a wrapper around
docker start,docker wait, anddocker stop. In the case of Kubernetes containers, there's some additional logic/checks on whether the container should be started or not; this is not fully implemented.Basic testing has been done with local containers (the most common use case).