-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Debianize for buildimage #9
Draft
erer1243
wants to merge
9
commits into
sonic-net:master
Choose a base branch
from
erer1243:debianize-for-buildimage
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+53
−32
Commits on Oct 21, 2024
-
Configuration menu - View commit details
-
Copy full SHA for fffe79e - Browse repository at this point
Copy the full SHA fffe79eView commit details -
Debian binary package stanzas do not have a Build-Depends field. These were previously just getting ignored
Configuration menu - View commit details
-
Copy full SHA for a199bdd - Browse repository at this point
Copy the full SHA a199bddView commit details -
All we depend on is protobuf version 3, and since protobuf follows semver, it should be safe to make this reduction
Configuration menu - View commit details
-
Copy full SHA for dfc2a50 - Browse repository at this point
Copy the full SHA dfc2a50View commit details
Commits on Oct 22, 2024
-
Configuration menu - View commit details
-
Copy full SHA for e35bdb6 - Browse repository at this point
Copy the full SHA e35bdb6View commit details -
Configuration menu - View commit details
-
Copy full SHA for 012004e - Browse repository at this point
Copy the full SHA 012004eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 4097a35 - Browse repository at this point
Copy the full SHA 4097a35View commit details -
Configuration menu - View commit details
-
Copy full SHA for 778cfad - Browse repository at this point
Copy the full SHA 778cfadView commit details
Commits on Oct 23, 2024
-
To run swss-common tests, we need redis installed. However, sonic-buildimage slave images specifically install mock redis packages to avoid installing real redis. Some packages skip their tests entirely because redis is not present in the buildimage (swss-common). So, I will follow in their footsteps and instead just turn off testing during .deb build, and we can instead have the tests as a separate CI run.
Configuration menu - View commit details
-
Copy full SHA for d7e4447 - Browse repository at this point
Copy the full SHA d7e4447View commit details -
Configuration menu - View commit details
-
Copy full SHA for 84e0f1f - Browse repository at this point
Copy the full SHA 84e0f1fView commit details
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.