GNOI Implementation of OS.Activate #351
Open
+249
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 5 out of 7 changed files in this pull request and generated no comments.
Files not reviewed (2)
- sonic_service_client/dbus_client_test.go: Evaluated as low risk
- common_utils/context.go: Evaluated as low risk
Comments suppressed due to low confidence (3)
gnoi_client/os/os.go:35
- [nitpick] The error message could be more descriptive. Consider changing it to 'Failed to unmarshal JSON: ' + err.Error()'.
panic(err.Error())
gnoi_client/os/os.go:39
- [nitpick] The error message could be more descriptive. Consider changing it to 'Failed to activate OS: ' + err.Error()'.
panic(err.Error())
gnoi_client/os/os.go:43
- [nitpick] The error message could be more descriptive. Consider changing it to 'Failed to marshal response: ' + err.Error()'.
panic(err.Error())
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
There was a problem hiding this comment.
Copilot reviewed 5 out of 8 changed files in this pull request and generated no comments.
Files not reviewed (3)
- gnoi_client/os/verify.go: Evaluated as low risk
- common_utils/context.go: Evaluated as low risk
- gnoi_client/gnoi_client.go: Evaluated as low risk
hdwhdw
requested review from
qiluo-msft,
ganglyu,
FengPan-Frank and
xincunli-sonic
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
qiluo-msft
reviewed
Feb 4, 2025
| @@ -56,6 +56,8 @@ func main() { | |||
| switch *config.Rpc { | |||
| case "Verify": | |||
| gnoi_os.Verify(conn, ctx) | |||
| case "Activate": | |||
There was a problem hiding this comment.
ganglyu
reviewed
Feb 5, 2025
gnmi_server/gnoi.go
Outdated
| @@ -161,6 +161,56 @@ func (srv *OSServer) Verify(ctx context.Context, req *gnoi_os_pb.VerifyRequest) | |||
| return resp, nil | |||
| } | |||
|
|
|||
| func (srv *OSServer) Activate(ctx context.Context, req *gnoi_os_pb.ActivateRequest) (*gnoi_os_pb.ActivateResponse, error) { | |||
| _, err := authenticate(srv.config, ctx, false) | |||
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
| if err != nil { | ||
| log.Errorf("Failed to activate image %s: %v", image, err) | ||
| image_not_exists := os.IsNotExist(err) || | ||
| (strings.Contains(strings.ToLower(err.Error()), "not") && |
There was a problem hiding this comment.
even with string check, could we use complete string match instead of "not" && "exist" which will have more corner cases.
There was a problem hiding this comment.
My main concern is error string equality check can easily have false negatives, say someone just remove a redundant space or any minor changes to the error string. Being that specific can make maintaining backend code difficult.
hdwhdw
requested review from
qiluo-msft,
FengPan-Frank,
xincunli-sonic and
ganglyu
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Support OS.Activate for GNOI.
How I did it
Implement OS.Activate.
How to verify it
On physical switch:
Which release branch to backport (provide reason below if selected)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)