Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed ip6table internal_docker_ip_traffic rule command for multi-asic #94

Merged
merged 2 commits into from
Dec 13, 2023

Conversation

anamehra
Copy link
Contributor

@anamehra anamehra commented Dec 6, 2023

Signed-off-by: anamehra [email protected]

Fixes: sonic-net/sonic-buildimage#17431

The self.namespace_docker_mgmt_ipv6[namespace] variable was being used as a string causing the cmd to fail.
Fixed the command.

Which release branch to backport (provide reason below if selected)

  • 202305

@anamehra
Copy link
Contributor Author

anamehra commented Dec 6, 2023

@gechiang , @abdosi , please review. Thanks

@anamehra
Copy link
Contributor Author

anamehra commented Dec 7, 2023

I am working on test case, will update soon.

Signed-off-by: anamehra <[email protected]>
Copy link

@gechiang gechiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@wenyiz2021 wenyiz2021 merged commit 722b796 into sonic-net:master Dec 13, 2023
5 checks passed
@wenyiz2021
Copy link

wenyiz2021 commented Dec 13, 2023

@anamehra this is also needed in 202211, 202305 branches
https://github.com/sonic-net/sonic-host-services/blame/3ebe922d17a15561495c2923c3c61ea298f6e799/scripts/caclmgrd#L312
original PR:
#34

mssonicbld pushed a commit to mssonicbld/sonic-host-services that referenced this pull request Dec 15, 2023
…sonic-net#94)

* Fixed ip6table internal_docker_ip_traffic rule command for multi-asic

* Added test coverage

Signed-off-by: anamehra <[email protected]>
@mssonicbld
Copy link

Cherry-pick PR to 202305: #96

mssonicbld pushed a commit that referenced this pull request Dec 20, 2023
…#94)

* Fixed ip6table internal_docker_ip_traffic rule command for multi-asic

* Added test coverage

Signed-off-by: anamehra <[email protected]>
mssonicbld pushed a commit to mssonicbld/sonic-host-services that referenced this pull request Feb 2, 2024
…sonic-net#94)

* Fixed ip6table internal_docker_ip_traffic rule command for multi-asic

* Added test coverage

Signed-off-by: anamehra <[email protected]>
@mssonicbld
Copy link

Cherry-pick PR to 202311: #102

mssonicbld pushed a commit that referenced this pull request Feb 2, 2024
…#94)

* Fixed ip6table internal_docker_ip_traffic rule command for multi-asic

* Added test coverage

Signed-off-by: anamehra <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

[202305] [multi-asic]: cacl test case failure due to missing ip6table rule in namspace
7 participants