[active-standby] Fix show mux status inconsistency introduced by orchagent rollback
#225
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
prsunny
reviewed
Dec 12, 2023
prsunny
previously approved these changes
Dec 12, 2023
prsunny
approved these changes
Dec 13, 2023
lolyu
approved these changes
Dec 13, 2023
|
@zjswhhh , would you raise a PR for 202205? |
zjswhhh
added a commit
to zjswhhh/sonic-linkmgrd
that referenced
this pull request
Dec 14, 2023
…chagent rollback (sonic-net#225) Approach What is the motivation for this PR? This is to fix the show mux status inconsistency introduced by orchagent roll back. In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback, show mux status can return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade. Hence, submitting this PR as a workaround. sign-off: Jing Zhang [email protected] Work item tracking Microsoft ADO (number only): 26136887 How did you do it? How did you verify/test it?
Merged
4 tasks
zjswhhh
added a commit
that referenced
this pull request
Dec 15, 2023
…chagent rollback (#225) (#226) Approach What is the motivation for this PR? This is to fix the show mux status inconsistency introduced by orchagent roll back. In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback, show mux status can return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade. Hence, submitting this PR as a workaround. sign-off: Jing Zhang [email protected] Work item tracking Microsoft ADO (number only): 26136887 How did you do it? How did you verify/test it?
|
@zjswhhh cherry pick conflict, could you help to raise separate PR for 202305? |
zjswhhh
added a commit
to zjswhhh/sonic-linkmgrd
that referenced
this pull request
Dec 18, 2023
…chagent rollback (sonic-net#225) Approach What is the motivation for this PR? This is to fix the show mux status inconsistency introduced by orchagent roll back. In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback, show mux status can return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade. Hence, submitting this PR as a workaround. sign-off: Jing Zhang [email protected] Work item tracking Microsoft ADO (number only): 26136887 How did you do it? How did you verify/test it?
4 tasks
StormLiangMS
pushed a commit
that referenced
this pull request
Dec 19, 2023
…ed by or… (#228) …chagent rollback (#225) Approach What is the motivation for this PR? This is to fix the show mux status inconsistency introduced by orchagent roll back. In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback, show mux status can return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade. Hence, submitting this PR as a workaround. sign-off: Jing Zhang [email protected] Work item tracking Microsoft ADO (number only): 26136887 How did you do it? How did you verify/test it?
mssonicbld
pushed a commit
to mssonicbld/sonic-linkmgrd
that referenced
this pull request
Feb 2, 2024
…chagent rollback (sonic-net#225) Approach What is the motivation for this PR? This is to fix the show mux status inconsistency introduced by orchagent roll back. In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback, show mux status can return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade. Hence, submitting this PR as a workaround. sign-off: Jing Zhang [email protected] Work item tracking Microsoft ADO (number only): 26136887 How did you do it? How did you verify/test it?
|
Cherry-pick PR to 202311: #243 |
mssonicbld
pushed a commit
that referenced
this pull request
Feb 2, 2024
…chagent rollback (#225) Approach What is the motivation for this PR? This is to fix the show mux status inconsistency introduced by orchagent roll back. In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback, show mux status can return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade. Hence, submitting this PR as a workaround. sign-off: Jing Zhang [email protected] Work item tracking Microsoft ADO (number only): 26136887 How did you do it? How did you verify/test it?
mssonicbld
added
Included in 202311 Branch
and removed
Created PR to 202311 Branch
labels
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of PR
Summary:
Fixes # (issue)
This is to fix the
show mux statusinconsistency introduced by orchagent roll back.In mux port state machine design, linkmgrd honors hardware state for active-standby ports, and never intends to trigger a secondary toggle when everything is healthy. But after we introduce orchagent rollback,
show mux statuscan return unmatched APP_DB and STATE_DB entries for this, which blocks upgrade.Hence, submitting this PR as a workaround.
sign-off: Jing Zhang [email protected]
Type of change
Approach
What is the motivation for this PR?
Work item tracking
26136887
How did you do it?
How did you verify/test it?
Any platform specific information?
Documentation