Use number of logs instead of timestamp in change_and_wait_aaa_config_update
#16723
+10
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
wenyiz2021
reviewed
Feb 3, 2025
| def change_and_wait_aaa_config_update(duthost, command, last_timestamp=None, timeout=10): | ||
| if not last_timestamp: | ||
| last_timestamp = get_auditd_config_reload_timestamp(duthost) | ||
| def change_and_wait_aaa_config_update(duthost, command, last_line_count=None, timeout=10): |
There was a problem hiding this comment.
just did a quick search and it shows besides test_accounting,py, there is test_ro_disk.py and test_authorization.py that call this function, please change accordingly.
|
Thanks for looking @wenyiz2021 I only changed the |
wenyiz2021
approved these changes
Feb 3, 2025
rlhui
approved these changes
Feb 6, 2025
arista-nwolfe
added a commit
to arista-nwolfe/sonic-mgmt.msft
that referenced
this pull request
Feb 10, 2025
Use number of logs instead of timestamp in change_and_wait_aaa_config_update sonic-net/sonic-mgmt#16723
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change_and_wait_aaa_config_updatevalidates that theauditdservice publishes the logaudisp-tacplus re-initializing configurationafter executing the passed incommand.However, it did this by checking that the timestamp in the log message was different than the previously emitted log.
As shown in #16709 these message can appear within the same second and cause the test to fail.
Instead this PR changes the approach to look at how many logs have been emitted before and after the command rather than the timestamp changes.
Summary:
Fixes #16709
Type of change
Back port request